Brew log days incorrect

Discussion in 'Brew Sessions' started by MeemoNZ, Apr 11, 2020.

  1. MeemoNZ

    MeemoNZ New Member

    Joined:
    May 14, 2019
    Messages:
    13
    Likes Received:
    2
    Trophy Points:
    3
    Location:
    Gisborne, NZ
    Just some feedback on the new Brew log... the days seems to be a little messed up... the default sort order also doesnt appear to be based on 'Date' which would make the most sense (I've ordered manually in the attached screen cap).

    Im NZ based, maybe its calculating the diff between US date format and my computers date format...?

    Other updates look good & info capture options look good!
     

    Attached Files:

  2. MeemoNZ

    MeemoNZ New Member

    Joined:
    May 14, 2019
    Messages:
    13
    Likes Received:
    2
    Trophy Points:
    3
    Location:
    Gisborne, NZ
    Oh and I just found this too.... they say time flies when you're having fun... Even with NZ Cvid-19 lockdown delusions, I dont think 207 days has passed for this brew! :)
     

    Attached Files:

  3. Yooper

    Yooper Administrator
    Staff Member

    Joined:
    Nov 16, 2013
    Messages:
    2,494
    Likes Received:
    1,582
    Trophy Points:
    113
    Gender:
    Female
    Occupation:
    Happily retired
    Location:
    Upper Michigan/Florida
    We've got the fix on beta right now, if you want to check it out: beta.brewersfriend.com You'd have to log in (and then make sure you return to the active site when you're done!). I'm working on it now, with testing. I apologize for this bug, and we're hoping to get it up and running later today.
     
    Brewer #64496 likes this.
  4. Yooper

    Yooper Administrator
    Staff Member

    Joined:
    Nov 16, 2013
    Messages:
    2,494
    Likes Received:
    1,582
    Trophy Points:
    113
    Gender:
    Female
    Occupation:
    Happily retired
    Location:
    Upper Michigan/Florida
    This has been fixed- sorry for the inconvenienced this caused you.
     
  5. MeemoNZ

    MeemoNZ New Member

    Joined:
    May 14, 2019
    Messages:
    13
    Likes Received:
    2
    Trophy Points:
    3
    Location:
    Gisborne, NZ
    Hi @Yooper

    Thanks for a quick response & fix, no inconvenience caused! The dates are now resolved - I had to edit & resubmit (changing the date from 4th November [11/4] to 4th April [4/11]).

    There also seems to be an issue with the 'Days' column, here are 2 screen caps - one of a previous recipe and one of the most recent... Which value is used to caluclate 0 days? Technically this should be the date of the earliest / 1st log entry ?

    Previous Brew Session.png Most recent brew session.png
     
    Pricelessbrewing likes this.
  6. Pricelessbrewing

    Pricelessbrewing QA Software Tester
    Staff Member

    Joined:
    Jun 8, 2016
    Messages:
    766
    Likes Received:
    503
    Trophy Points:
    93
    Gender:
    Male
    We're already having a discussion about that, but I believe yooper and myself are in agreement with you. The days should be since brewday.
     
    MeemoNZ likes this.
  7. MeemoNZ

    MeemoNZ New Member

    Joined:
    May 14, 2019
    Messages:
    13
    Likes Received:
    2
    Trophy Points:
    3
    Location:
    Gisborne, NZ
    I think I have found another issue, I've just added a log entry, I left the time as 'now' but it seems theres a problem with timezone / conversion of time for the graph...
     

    Attached Files:

  8. Yooper

    Yooper Administrator
    Staff Member

    Joined:
    Nov 16, 2013
    Messages:
    2,494
    Likes Received:
    1,582
    Trophy Points:
    113
    Gender:
    Female
    Occupation:
    Happily retired
    Location:
    Upper Michigan/Florida
    We are working on this right now! I'll keep you posted when it's fixed. I'm sorry for the issues you've been having.
     
    MeemoNZ likes this.
  9. OrbDog

    OrbDog New Member

    Joined:
    Oct 16, 2015
    Messages:
    11
    Likes Received:
    3
    Trophy Points:
    3
    I confirm that this also fxes a different issue, where within the Inventory the "Amount" sort is incorrect.

    For example in the current release, volumes > 10 are not properly ordered. See attached pic of comparison between how the current, live site and beta handles the sorting.
     

    Attached Files:

  10. Pricelessbrewing

    Pricelessbrewing QA Software Tester
    Staff Member

    Joined:
    Jun 8, 2016
    Messages:
    766
    Likes Received:
    503
    Trophy Points:
    93
    Gender:
    Male
    This is an unrelated issue that's also being tested on beta. Everything looks good, just waiting on the code review before pushing the fix to the live site.
     
    OrbDog likes this.
  11. 8^bit Homebrew

    8^bit Homebrew New Member

    Joined:
    Jul 11, 2019
    Messages:
    1
    Likes Received:
    1
    Trophy Points:
    3
    Location:
    Townsville, Queensland, Australia
    Hi,
    I'm in Aus and also had these issues. Thanks very much for fixing.

    I have one remaining related issue, I can't seem to change brew log times. They are always set to the current time every time I save, regardless of what is in the datetime picker.
     
    Pricelessbrewing likes this.
  12. Pricelessbrewing

    Pricelessbrewing QA Software Tester
    Staff Member

    Joined:
    Jun 8, 2016
    Messages:
    766
    Likes Received:
    503
    Trophy Points:
    93
    Gender:
    Male
    Thanks for reporting, a fix for this should be ready shortly. Just waiting on code review before releasing
     
    8^bit Homebrew likes this.

Share This Page

arrow_white